[v2.0 Geoscape] Engineering quantity change prerequisite checks incorrect

[wulf 21]

Reproducable with following save-file (after researching comba armor): combat_armor_researched.json

1. go to engineering screen
2. add one combat armor to queue. Result: 160$ left. Quantity-up-button not greyed out and quantity-down-button greyed out - OK (Screenshot 1)
3. click quantity-up 1 time. Result: Quantity is 2. Only 60$ left. Quantity-down button not greyed out but quantity up-button not greyed out either - NOK, expected: quantity up should be greyed out because not enough money (Screenshot 2)
4. click quantity-up again. Result: nothing happens - OK
5. click quantity-down. Result: Quantity is 1. Again 160$ left. Quantity-down and up are both greyed out - NOK, expected: quantity-up should not be greyed out because there is enough money to increase it (Screenshot 3)
6. click quantity-up - Result: nothing happens - NOK, expected: it should be possible to increase quantity as we have the met prerequisites

So it looks like the piece of code that determines if we met the prerequisites to increase quantity (and greys out the button if not) actually uses the prerequisite state from before the quantity change, not the state after. As a workaround, it is possible to remove the item completely from queue and add it again, then quantity can be changed up again.

Another note: If the add combat armor is clicked 2 times with queue empty, it would add 2 lines: 1xcombat armor, 1x combat armor instead of 2x combat armor. I suppose this is not a bug since the player could have the intention to produce for example item A, item B, item A instead of 2x item A, item B. However it would make kind of sense if the add project button would increase quantity instead if it is the same project that is already at the end of the list.

Screenshot 1:

Screenshot 2:

Screenshot 3:

Edited February 3, 2019 by wulf 21

[Chris]

Thanks. I know this is an old report but I've managed to reproduce and log this issue anyway.