[v2.0 Geoscape] Crash when disbanding airborne squadron

[wulf 21]

Found yet another way to crash the game:

1. launch an interceptor
2. click the base it was launched from
3. click the hangar of the interceptor
4. click disband
5. click yes

Looks lie some part of the code then destroys the entity while another part that does the flying still tries to update it.

2019-02-03 22:12:46,137 [INFO] (D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Screens\Strategy\Systems\Geoscape\WaypointSystem.cs:31) 
Delete Waypoint 277:Waypoint

2019-02-03 22:12:46,146 [FATAL] (D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Screens\XenonautsMain.cs:441) 
A fatal error occurred during Update() - 
System.Exception: Entity 261 was deleted and cannot be modified after destruction. Please use IsAlive() when modifying. Mutation: null into Common.RPG.RangeModifierStorageComponent
  at Artitas.World.MutateComponentOnEntity (Int32 entityID, Int32 componentID, IComponent previousC, IComponent nextC, Boolean added) [0x0003d] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\World.cs:297 
  at Artitas.Entity.Add (IComponent newComponent, Int32 componentId) [0x00017] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\Entity.cs:57 
  at Common.RPG.ModifierSystem.HandleRangeModifier (Artitas.Entity target, Common.RPG.Modifier`1 modifier, Boolean added, Int32 storageComponentIdx, System.Collections.Generic.Dictionary`2 modificationStrategies, Common.RPG.ModificationStrategy`1 defaultModificationStrategy, Common.RPG.ApplicationStrategy`1 applicationStrategy) [0x00020] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Common\Code\Gameplay\RPG\ModifierSystem.cs:209 
  at Common.RPG.ModifierSystem.Handle (Common.RPG.ModifierEvent event) [0x0005c] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Common\Code\Gameplay\RPG\ModifierSystem.cs:105 
  at (wrapper delegate-invoke) System.Action`2<Common.RPG.ModifierSystem, Common.RPG.ModifierEvent>:invoke_void__this___ModifierSystem_ModifierEvent (Common.RPG.ModifierSystem,Common.RPG.ModifierEvent)
  at Artitas.Core.Utils.ExpressionUtil+<ActionFromMethodInfoFactory>c__AnonStorey1`4[Artitas.Systems.EventSystem,Common.RPG.ModifierEvent,Common.RPG.ModifierSystem,Artitas.IEvent].<>m__0 (Artitas.Systems.EventSystem target, IEvent param) [0x0001c] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\Utils\ExpressionUtil.cs:151 
  at Artitas.Systems.EventSystem.HandleSubscribers (IEvent event) [0x00050] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\Systems\EventSystem.cs:49 
  at Artitas.Systems.EventSystem.Handle (IEvent event) [0x00003] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\Systems\EventSystem.cs:26 
  at Artitas.DefaultProcessStrategy.Process (IEvent event) [0x001c6] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\World.cs:830 
  at Artitas.DefaultProcessStrategy.Process () [0x00024] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\World.cs:773 
  at Artitas.World.Process () [0x00007] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Artitas\Artitas.Core\Code\World.cs:643 
  at Common.Screens.DataStructures.WorldManagedScreen`2[Xenonauts.GameScreens,Common.Screens.DataStructures.IScreenParameters].Update (Single deltaTime) [0x00032] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Common\Code\Lifecycles\ScreenLifecycle\DataStructures\WorldManagedScreen.cs:49 
  at Common.Screens.ScreenManager`1[Xenonauts.GameScreens].Update (Single deltaTime) [0x000f3] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Libraries\Common\Code\Lifecycles\ScreenLifecycle\ScreenManager.cs:149 
  at Xenonauts.XenonautsMain.Update () [0x00066] in D:\Jenkins\workspace\X2 (Build)\release-0.37.0\Assets\Code\Screens\XenonautsMain.cs:438 

Attached: output.zip

[Chris]

Thanks. Yeah, the relocate / disband functionality needs to be looked at as a whole, which should fix this up.