[0.27] Short Range Accuracy Distance Variable Doesn't Work

[kabill]

I reported this a while back but have now been able to confirm it using the debugger. (I'd link the original thread, but I can't find it).

The problematic variable is this one in config:

<ShortRangeHitBonusMinDistance></ShortRangeHitBonusMinDistance>

By default, it's 5. But changing it doesn't make any difference. For example, I changed it to 12 and this was reflected in the displayed to-hit scores, but not in the actual game's calculation of the shot. From the debugger:

[1312] short range hit bonus (7.639) = (5 - dist. to target (4.472) + 1) * short range hit bonus per tile (5)

The number in red, from what I can tell, is the short range distance value, which has retained it's vanilla value. Some extensive testing previously implied that this was the case empirically (hit chances were much lower than they should have been, and when up when I reverted the changes).